netdev - Re: [PATCH net-next 7/7] gtp: update rx_length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 14:00:55 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jonas Bonn <jonas@...rbonn.se>
Cc:     laforge@...monks.org, netdev@...r.kernel.org, pablo@...filter.org
Subject: Re: [PATCH net-next 7/7] gtp: update rx_length_errors for
 abnormally short packets

On Tue,  2 Feb 2021 07:51:59 +0100 Jonas Bonn wrote:
> diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
> index a1bb02818977..fa8880c51101 100644
> --- a/drivers/net/gtp.c
> +++ b/drivers/net/gtp.c
> @@ -189,8 +189,10 @@ static int gtp_rx(struct pdp_ctx *pctx, struct sk_buff *skb,
>  
>  	/* Get rid of the GTP + UDP headers. */
>  	if (iptunnel_pull_header(skb, hdrlen, skb->protocol,
> -				 !net_eq(sock_net(pctx->sk), dev_net(pctx->dev))))
> -		return -1;
> +			 !net_eq(sock_net(pctx->sk), dev_net(pctx->dev)))) {
> +		gtp->dev->stats.rx_length_errors++;
> +		goto err;
> +	}
>  
>  	netdev_dbg(pctx->dev, "forwarding packet from GGSN to uplink\n");
>  
> @@ -206,6 +208,10 @@ static int gtp_rx(struct pdp_ctx *pctx, struct sk_buff *skb,
>  
>  	netif_rx(skb);
>  	return 0;
> +
> +err:
> +	gtp->dev->stats.rx_dropped++;
> +	return -1;
>  }
>  
>  /* 1 means pass up to the stack, -1 means drop and 0 means decapsulated. */

drivers/net/gtp.c: In function ‘gtp_rx’:
drivers/net/gtp.c:193:3: error: ‘gtp’ undeclared (first use in this function)
  193 |   gtp->dev->stats.rx_length_errors++;
      |   ^~~
drivers/net/gtp.c:193:3: note: each undeclared identifier is reported only once for each function it appears in


Thanks for working on these patches!