netdev - Re: [PATCH 0/2] chelsio: cxgb: Use threaded interrupts for deferred work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210203090336.qtikut5qjbgzbtkm@linutronix.de>
Date:   Wed, 3 Feb 2021 10:03:36 +0100
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Ahmed S. Darwish" <a.darwish@...utronix.de>
Subject: Re: [PATCH 0/2] chelsio: cxgb: Use threaded interrupts for deferred
 work

On 2021-02-02 17:31:23 [-0800], Jesse Brandeburg wrote:
> Sebastian Andrzej Siewior wrote:
> 
> > Patch #2 fixes an issue in which del_timer_sync() and tasklet_kill() is
> > invoked from the interrupt handler. This is probably a rare error case
> > since it disables interrupts / the card in that case.
> > Patch #1 converts a worker to use a threaded interrupt which is then
> > also used in patch #2 instead adding another worker for this task (and
> > flush_work() to synchronise vs rmmod).
> > 
> > This has been only compile tested.
> 
> Hi! Thanks for your patch. Do all drivers that use worker threads need
> to convert like this or only some?

There is no need but it does makes things easier.

> In future revisions, please indicate the tree
> you're targeting, net or net-next.  ie [PATCH net-next v1] I'd also
> invert the two paragraphs and talk about patch #1 first.

I left it out on purpose since I have no chance on testing the change I
made. Technically both fix something and the bug was there since day
one and it is not something you likely trigger.

> Jesse

Sebastian