netdev - RE: [PATCH net-next 6/6] i40e: Log error for oversized MTU on device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB28761B036F7DDDFBE7D53CB5E5B49@DM6PR11MB2876.namprd11.prod.outlook.com>
Date:   Wed, 3 Feb 2021 09:14:24 +0000
From:   "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "Rybak, Eryk Roch" <eryk.roch.rybak@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Topel, Bjorn" <bjorn.topel@...el.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        "Bhandare, KiranX" <kiranx.bhandare@...el.com>
Subject: RE: [PATCH net-next 6/6] i40e: Log error for oversized MTU on device

Good day Jakub

We want to be user friendly to help users troubleshoot faster.
Only dmesg message can have template parameters so we can provide exact acceptable maximum bytes.
Can you could you take this into account?

Thank you


-----Original Message-----
From: Jakub Kicinski <kuba@...nel.org> 
Sent: Wednesday, February 3, 2021 3:35 AM
To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net; Rybak, Eryk Roch <eryk.roch.rybak@...el.com>; netdev@...r.kernel.org; sassmann@...hat.com; Topel, Bjorn <bjorn.topel@...el.com>; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>; Karlsson, Magnus <magnus.karlsson@...el.com>; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Bhandare, KiranX <kiranx.bhandare@...el.com>
Subject: Re: [PATCH net-next 6/6] i40e: Log error for oversized MTU on device

On Mon,  1 Feb 2021 18:24:20 -0800 Tony Nguyen wrote:
> From: Eryk Rybak <eryk.roch.rybak@...el.com>
> 
> When attempting to link XDP prog with MTU larger than supported, user 
> is not informed why XDP linking fails. Adding proper error message: 
> "MTU too large to enable XDP".
> Due to the lack of support for non-static variables in netlinks 
> extended ACK feature, additional information has been added to dmesg 
> to better inform about invalid MTU setting.
> 
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Signed-off-by: Eryk Rybak <eryk.roch.rybak@...el.com>
> Tested-by: Kiran Bhandare <kiranx.bhandare@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

> @@ -12459,8 +12460,13 @@ static int i40e_xdp_setup(struct i40e_vsi *vsi,
>  	int i;
>  
>  	/* Don't allow frames that span over multiple buffers */
> -	if (frame_size > vsi->rx_buf_len)
> +	if (frame_size > vsi->rx_buf_len) {
> +		NL_SET_ERR_MSG_MOD(extack, "MTU too large to enable XDP");
> +		dev_info(&pf->pdev->dev,
> +			 "MTU of %u bytes is too large to enable XDP (maximum: %u bytes)\n",
> +			 vsi->netdev->mtu, vsi->rx_buf_len);

Extack should be enough.
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Sowackiego 173 | 80-298 Gdask | Sd Rejonowy Gdask Pnoc | VII Wydzia Gospodarczy Krajowego Rejestru Sdowego - KRS 101882 | NIP 957-07-52-316 | Kapita zakadowy 200.000 PLN.
Ta wiadomo wraz z zacznikami jest przeznaczona dla okrelonego adresata i moe zawiera informacje poufne. W razie przypadkowego otrzymania tej wiadomoci, prosimy o powiadomienie nadawcy oraz trwae jej usunicie; jakiekolwiek przegldanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.