netdev - Re: [PATCHv5 net-next 2/2] rxrpc: call udp_tunnel_encap_enable in rxrpc_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <707366.1612345842@warthog.procyon.org.uk>
Date:   Wed, 03 Feb 2021 09:50:42 +0000
From:   David Howells <dhowells@...hat.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     dhowells@...hat.com, network dev <netdev@...r.kernel.org>,
        davem@...emloft.net, Jakub Kicinski <kuba@...nel.org>,
        pabeni@...hat.com, Willem de Bruijn <willemb@...gle.com>,
        Martin Varghese <martin.varghese@...ia.com>,
        Alexander Duyck <alexander.duyck@...il.com>
Subject: Re: [PATCHv5 net-next 2/2] rxrpc: call udp_tunnel_encap_enable in rxrpc_open_socket

Xin Long <lucien.xin@...il.com> wrote:

> When doing encap_enable/increasing encap_needed_key, up->encap_enabled
> is not set in rxrpc_open_socket(), and it will cause encap_needed_key
> not being decreased in udpv6_destroy_sock().
> 
> This patch is to improve it by just calling udp_tunnel_encap_enable()
> where it increases both UDP and UDPv6 encap_needed_key and sets
> up->encap_enabled.
> 
> v4->v5:
>   - add the missing '#include <net/udp_tunnel.h>', as David Howells
>     noticed.
> 
> Acked-and-tested-by: David Howells <dhowells@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Looks good.

David