netdev - Re: [PATCH v2 2/2] ibmvnic: fix race with multiple open/close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Feb 2021 12:56:52 -0800
From:   Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        Dany Madden <drt@...ux.ibm.com>, Lijun Pan <ljp@...ux.ibm.com>,
        Rick Lindsley <ricklind@...ux.ibm.com>, abdhalee@...ibm.com
Subject: Re: [PATCH v2 2/2] ibmvnic: fix race with multiple open/close

Willem de Bruijn [willemdebruijn.kernel@...il.com] wrote:
> On Wed, Feb 3, 2021 at 12:10 AM Sukadev Bhattiprolu
> <sukadev@...ux.ibm.com> wrote:
> >
> > If two or more instances of 'ip link set' commands race and first one
> > already brings the interface up (or down), the subsequent instances
> > can simply return without redoing the up/down operation.
> >
> > Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
> > Reported-by: Abdul Haleem <abdhalee@...ibm.com>
> > Tested-by: Abdul Haleem <abdhalee@...ibm.com>
> > Signed-off-by: Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
> >
> > ---
> > Changelog[v2] For consistency with ibmvnic_open() use "goto out" and return
> >               from end of function.
> 
> Did you find the code path that triggers this?

Not yet. I need to find time on the system to repro/debug that
> 
> In v1 we discussed how the usual ip link path should not call the
> driver twice based on IFF_UP.

Yes, we can hold this patch for now if necessary. Hopefully Patch 1/2 is
ok.

Sukadev