lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Feb 2021 18:33:52 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Tony Nguyen <anthony.l.nguyen@...el.com> Cc: davem@...emloft.net, Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>, netdev@...r.kernel.org, sassmann@...hat.com, bjorn.topel@...el.com, maciej.fijalkowski@...el.com, magnus.karlsson@...el.com, Aleksandr Loktionov <aleksandr.loktionov@...el.com>, George Kuruvinakunnel <george.kuruvinakunnel@...el.com> Subject: Re: [PATCH net-next 5/6] i40e: Add info trace at loading XDP program On Mon, 1 Feb 2021 18:24:19 -0800 Tony Nguyen wrote: > From: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com> > > New trace indicates that the XDP program was loaded. > The trace has a note that in case of using XDP_REDIRECT, > number of queues on both interfaces shall be the same. > This is required for optimal performance of XDP_REDIRECT, > if interface used for TX has lower number of queues than > a RX interface, the packets may be dropped (depending on > RSS queue assignment). By RSS queue assignment you mean interrupt mapping? > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c > index 521ea9df38d5..f35bd9164106 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -12489,11 +12489,14 @@ static int i40e_xdp_setup(struct i40e_vsi *vsi, > /* Kick start the NAPI context if there is an AF_XDP socket open > * on that queue id. This so that receiving will start. > */ > - if (need_reset && prog) > + if (need_reset && prog) { > + dev_info(&pf->pdev->dev, > + "Loading XDP program, please note: XDP_REDIRECT action requires the same number of queues on both interfaces\n"); We try to avoid spamming logs. This message will be helpful to users only the first time, if at all.
Powered by blists - more mailing lists