netdev - Re: [PATCH net] net/sched: cls_flower: Return invalid for unknown ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210204182310.GN3399@horizon.localdomain>
Date:   Thu, 4 Feb 2021 15:23:10 -0300
From:   Marcelo Ricardo Leitner <mleitner@...hat.com>
To:     wenxu <wenxu@...oud.cn>
Cc:     i.maximets@....org, netdev@...r.kernel.org
Subject: Re: [PATCH net] net/sched: cls_flower: Return invalid for unknown
 ct_state flags rules

On Thu, Feb 04, 2021 at 11:50:53PM +0800, wenxu wrote:
> 
> 在 2021/2/4 21:38, Marcelo Ricardo Leitner 写道:
> > Hi,
> >
> > On Thu, Feb 04, 2021 at 12:17:24PM +0800, wenxu@...oud.cn wrote:
> >> From: wenxu <wenxu@...oud.cn>
> >>
> >> Reject the unknown ct_state flags of cls flower rules. This also make
> >> the userspace like ovs to probe the ct_state flags support in the
> >> kernel.
> > That's a good start but it could also do some combination sanity
> > checks, like ovs does in validate_ct_state(). For example, it does:
> >
> >       if (state && !(state & CS_TRACKED)) {
> >           ds_put_format(ds, "%s: invalid connection state: "
> >                         "If \"trk\" is unset, no other flags are set\n",
> >
> So this sanity checks maybe also need to be added in the ovs kernel modules?
> 
> The kernel datapath can work without ovs-vswitchd.

IMHO that would be nice, yes.

  Marcelo