netdev - Re: [net v4] selftests: txtimestamp: fix compilation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-LgMjFt11kSvNUbwS-pXZdnucF8UxNZjyGUvJQcKyU-8w@mail.gmail.com>
Date:   Thu, 4 Feb 2021 13:57:48 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Vadim Fedorenko <vfedorenko@...ek.ru>
Cc:     Jakub Kicinski <kuba@...nel.org>, Jian Yang <jianyang@...gle.com>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [net v4] selftests: txtimestamp: fix compilation issue

On Thu, Feb 4, 2021 at 12:51 PM Vadim Fedorenko <vfedorenko@...ek.ru> wrote:
>
> PACKET_TX_TIMESTAMP is defined in if_packet.h but it is not included in
> test. Include it instead of <netpacket/packet.h> otherwise the error of
> redefinition arrives.
> Also fix the compiler warning about ambiguous control flow by adding
> explicit braces.
>
> Fixes: 8fe2f761cae9 ("net-timestamp: expand documentation")
> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Signed-off-by: Vadim Fedorenko <vfedorenko@...ek.ru>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Thanks for fixing this, Vadim.