netdev - Re: [PATCH net v2] net/sched: cls_flower: Reject invalid ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210204124933.1f921bfe@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 4 Feb 2021 12:49:33 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Marcelo Ricardo Leitner <mleitner@...hat.com>, wenxu@...oud.cn
Cc:     jhs@...atatu.com, netdev@...r.kernel.org,
        Ilya Maximets <i.maximets@....org>
Subject: Re: [PATCH net v2] net/sched: cls_flower: Reject invalid ct_state
 flags rules

On Thu, 4 Feb 2021 12:51:01 -0300 Marcelo Ricardo Leitner wrote:
> On Thu, Feb 04, 2021 at 11:46:11PM +0800, wenxu@...oud.cn wrote:
> > From: wenxu <wenxu@...oud.cn>
> > 
> > Reject the unsupported and invalid ct_state flags of cls flower rules.
> > 
> > Fixes: e0ace68af2ac ("net/sched: cls_flower: Add matching on conntrack info")
> >   
> 
> Hopefully Jakub can strip the blank line above.

Let's do one more spin, actually. Please remove this empty line between
tags wenxu.

> > +	if (state & ~TCA_FLOWER_KEY_CT_FLAGS_MASK) {
> > +		NL_SET_ERR_MSG_MOD(extack, "unsupported ct_state flags");
> > +		return -EINVAL;
> > +	}

For this check - can we use NLA_POLICY_MASK() please?

I wonder if we should use NL_SET_ERR_MSG_ATTR() for other checks.
Sadly there's no macro for both MOD and ATTR, and this is a fix,
but ATTR is probably far more informative than the module name so
I'd go with ATTR.