netdev - Re: [PATCH] net/vmw_vsock: fix NULL pointer deref and improve locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Feb 2021 23:22:42 +0100
From:   Norbert Slusarek <nslusarek@....net>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Stefano Garzarella <sgarzare@...hat.com>, alex.popov@...ux.com,
        kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net/vmw_vsock: fix NULL pointer deref and improve
 locking

> We request Fixes: tag for patches targeting net tree.
>
> You could also mention the vsock_connect_timeout()
> issue was found by a reviewer and give some credits ;)

You're right, Eric Dumazet spotted the locking problem in vsock_cancel_timeout().
I am not too familiar how I should format my response to include it to the final
patch message, in case I should specifically format it, just let me know.
For now:

Fixes: 380feae0def7e6a115124a3219c3ec9b654dca32 (vsock: cancel packets when failing to connect)
Reported-by: Norbert Slusarek <nslusarek@....net>
Reported-by: Eric Dumazet <eric.dumazet@...il.com>