netdev - Re: [PATCH net-next 2/7] net: hns3: RSS indirection table and key use device specifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Feb 2021 11:30:04 +0800
From:   Huazhong Tan <tanhuazhong@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>,
        <huangdaode@...wei.com>, <linuxarm@...neuler.org>,
        Guangbin Huang <huangguangbin2@...wei.com>
Subject: Re: [PATCH net-next 2/7] net: hns3: RSS indirection table and key use
 device specifications


On 2021/2/4 8:50, Jakub Kicinski wrote:
> On Tue, 2 Feb 2021 20:39:48 +0800 Huazhong Tan wrote:
>>   struct hclgevf_rss_cfg {
>> -	u8  rss_hash_key[HCLGEVF_RSS_KEY_SIZE]; /* user configured hash keys */
>> +	/* user configured hash keys */
>> +	u8  rss_hash_key[HCLGEVF_RSS_KEY_SIZE_MAX];
>>   	u32 hash_algo;
>>   	u32 rss_size;
>>   	u8 hw_tc_map;
>> -	u8  rss_indirection_tbl[HCLGEVF_RSS_IND_TBL_SIZE]; /* shadow table */
>> +	/* shadow table */
>> +	u8  rss_indirection_tbl[HCLGEVF_RSS_IND_TBL_SIZE_MAX];
>>   	struct hclgevf_rss_tuple_cfg rss_tuple_sets;
>>   };
> What if the table sizes supported by the device grow beyond the
> .._SIZE_MAX constants? Are you handling that case?

Sorry for missing this case, will allocate these tables by the queried 
size instead

of this fixed one, Since some verification job is needed, so this patch 
will resend later.

thanks.
> .