netdev - Re: [PATCH net-next 2/2] net: stmmac: slightly adjust the order of the codes in stmmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF=yD-JkNrzwDsdBmEVv24erNa94YbkfJHGCkF+DwfJYa2UcfQ@mail.gmail.com>
Date:   Fri, 5 Feb 2021 10:41:40 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Jose Abreu <joabreu@...opsys.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 2/2] net: stmmac: slightly adjust the order of
 the codes in stmmac_resume()

On Thu, Feb 4, 2021 at 8:18 PM Joakim Zhang <qiangqing.zhang@....com> wrote:
>
>
> > -----Original Message-----
> > From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> > Sent: 2021年2月4日 21:20
> > To: Joakim Zhang <qiangqing.zhang@....com>
> > Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>; Alexandre Torgue
> > <alexandre.torgue@...com>; Jose Abreu <joabreu@...opsys.com>; David
> > Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Network
> > Development <netdev@...r.kernel.org>; Andrew Lunn <andrew@...n.ch>;
> > Florian Fainelli <f.fainelli@...il.com>; Willem de Bruijn
> > <willemdebruijn.kernel@...il.com>
> > Subject: Re: [PATCH net-next 2/2] net: stmmac: slightly adjust the order of the
> > codes in stmmac_resume()
> >
> > On Thu, Feb 4, 2021 at 5:18 AM Joakim Zhang <qiangqing.zhang@....com>
> > wrote:
> > >
> > > Slightly adjust the order of the codes in stmmac_resume(), remove the
> > > check "if (!device_may_wakeup(priv->device) || !priv->plat->pmt)".
> > >
> > > Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
> >
> > This commit message says what the code does, but not why or why it's correct.
>
> This just slight changes the code order, there is no function change, I will improve the commit message if needed.

And it is correct to move this phylink initialization before serdes_powerup?

That is not immediately obvious to me. A comment would definitely be
good. More relevant than just stating that the code is moved, which I
see from the patch easily.