netdev - Re: [PATCH iproute2-next v3] tc/htb: Hierarchical QoS hardware offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <acd468c6-c3cd-f7eb-7ef8-0d029f198feb@gmail.com>
Date:   Thu, 4 Feb 2021 21:57:52 -0700
From:   David Ahern <dsahern@...il.com>
To:     Maxim Mikityanskiy <maximmi@...lanox.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     Tariq Toukan <tariqt@...dia.com>,
        Yossi Kuperman <yossiku@...dia.com>,
        Maxim Mikityanskiy <maximmi@...dia.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next v3] tc/htb: Hierarchical QoS hardware
 offload

On 2/4/21 7:51 AM, Maxim Mikityanskiy wrote:
> This commit adds support for configuring HTB in offload mode. HTB
> offload eliminates the single qdisc lock in the datapath and offloads
> the algorithm to the NIC. The new 'offload' parameter is added to
> enable this mode:
> 
>     # tc qdisc replace dev eth0 root handle 1: htb offload
> 
> Classes are created as usual, but filters should be moved to clsact for
> lock-free classification (filters attached to HTB itself are not
> supported in the offload mode):
> 
>     # tc filter add dev eth0 egress protocol ip flower dst_port 80
>     action skbedit priority 1:10
> 
> tc qdisc show and tc class show will indicate whether the offload is
> enabled. Example output:
> 
> $ tc qdisc show dev eth1
> qdisc htb 1: root offloaded r2q 10 default 0 direct_packets_stat 0 direct_qlen 1000 offload
> qdisc pfifo 0: parent 1: limit 1000p
> qdisc pfifo 0: parent 1: limit 1000p
> qdisc pfifo 0: parent 1: limit 1000p
> qdisc pfifo 0: parent 1: limit 1000p
> qdisc pfifo 0: parent 1: limit 1000p
> qdisc pfifo 0: parent 1: limit 1000p
> qdisc pfifo 0: parent 1: limit 1000p
> qdisc pfifo 0: parent 1: limit 1000p
> $ tc class show dev eth1
> class htb 1:101 parent 1:1 prio 0 rate 4Gbit ceil 4Gbit burst 1000b cburst 1000b  offload
> class htb 1:1 root rate 100Gbit ceil 100Gbit burst 0b cburst 0b  offload
> class htb 1:103 parent 1:1 prio 0 rate 4Gbit ceil 4Gbit burst 1000b cburst 1000b  offload
> class htb 1:102 parent 1:1 prio 0 rate 4Gbit ceil 4Gbit burst 1000b cburst 1000b  offload
> class htb 1:105 parent 1:1 prio 0 rate 4Gbit ceil 4Gbit burst 1000b cburst 1000b  offload
> class htb 1:104 parent 1:1 prio 0 rate 4Gbit ceil 4Gbit burst 1000b cburst 1000b  offload
> class htb 1:107 parent 1:1 prio 0 rate 4Gbit ceil 4Gbit burst 1000b cburst 1000b  offload
> class htb 1:106 parent 1:1 prio 0 rate 4Gbit ceil 4Gbit burst 1000b cburst 1000b  offload
> class htb 1:108 parent 1:1 prio 0 rate 4Gbit ceil 4Gbit burst 1000b cburst 1000b  offload
> $ tc -j qdisc show dev eth1
> [{"kind":"htb","handle":"1:","root":true,"offloaded":true,"options":{"r2q":10,"default":"0","direct_packets_stat":0,"direct_qlen":1000,"offload":null}},{"kind":"pfifo","handle":"0:","parent":"1:","options":{"limit":1000}},{"kind":"pfifo","handle":"0:","parent":"1:","options":{"limit":1000}},{"kind":"pfifo","handle":"0:","parent":"1:","options":{"limit":1000}},{"kind":"pfifo","handle":"0:","parent":"1:","options":{"limit":1000}},{"kind":"pfifo","handle":"0:","parent":"1:","options":{"limit":1000}},{"kind":"pfifo","handle":"0:","parent":"1:","options":{"limit":1000}},{"kind":"pfifo","handle":"0:","parent":"1:","options":{"limit":1000}},{"kind":"pfifo","handle":"0:","parent":"1:","options":{"limit":1000}}]
> 
> Signed-off-by: Maxim Mikityanskiy <maximmi@...lanox.com>
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> ---
>  man/man8/tc-htb.8 |  5 ++++-
>  tc/q_htb.c        | 10 +++++++++-
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 

applied to iproute2-next. Thanks