lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Feb 2021 15:25:59 +0800 From: Xulin Sun <xulin.sun@...driver.com> To: wg@...ndegger.com, mkl@...gutronix.de Cc: dmurphy@...com, sriram.dash@...sung.com, kuba@...nel.org, davem@...emloft.net, linux-can@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, xulin.sun@...driver.com, xulinsun@...il.com Subject: [PATCH 2/2] can: m_can: m_can_class_allocate_dev(): remove impossible error return judgment If the previous can_net device has been successfully allocated, its private data structure is impossible to be empty, remove this redundant error return judgment. Otherwise, memory leaks for alloc_candev() will be triggered. Signed-off-by: Xulin Sun <xulin.sun@...driver.com> --- drivers/net/can/m_can/m_can.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 02c5795b7393..042940088d41 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1797,11 +1797,6 @@ struct m_can_classdev *m_can_class_allocate_dev(struct device *dev) } class_dev = netdev_priv(net_dev); - if (!class_dev) { - dev_err(dev, "Failed to init netdev cdevate"); - goto out; - } - class_dev->net = net_dev; class_dev->dev = dev; SET_NETDEV_DEV(net_dev, dev); -- 2.17.1
Powered by blists - more mailing lists