netdev - RE: [PATCH net v2 0/3] dpaa_eth: A050385 erratum workaround fixes under XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Feb 2021 08:29:59 +0000
From:   "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>
To:     Camelia Alexandra Groza <camelia.groza@....com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "maciej.fijalkowski@...el.com" <maciej.fijalkowski@...el.com>
CC:     "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net v2 0/3] dpaa_eth: A050385 erratum workaround fixes
 under XDP

> -----Original Message-----
> From: Camelia Alexandra Groza <camelia.groza@....com>
> Sent: 04 February 2021 18:49
> To: kuba@...nel.org; davem@...emloft.net; maciej.fijalkowski@...el.com
> Cc: Madalin Bucur (OSS) <madalin.bucur@....nxp.com>;
> netdev@...r.kernel.org; Camelia Alexandra Groza <camelia.groza@....com>
> Subject: [PATCH net v2 0/3] dpaa_eth: A050385 erratum workaround fixes
> under XDP
> 
> This series addresses issue with the current workaround for the A050385
> erratum in XDP scenarios.
> 
> The first patch makes sure the xdp_frame structure stored at the start of
> new buffers isn't overwritten.
> 
> The second patch decreases the required data alignment value, thus
> preventing unnecessary realignments.
> 
> The third patch moves the data in place to align it, instead of allocating
> a new buffer for each frame that breaks the alignment rules, thus bringing
> an up to 40% performance increase. With this change, the impact of the
> erratum workaround is reduced in many cases to a single digit decrease,
> and
> to lower double digits in single flow scenarios.
> 
> Changes in v2:
> - guarantee enough tailroom is available for the shared_info in 1/3
> 
> Camelia Groza (3):
>   dpaa_eth: reserve space for the xdp_frame under the A050385 erratum
>   dpaa_eth: reduce data alignment requirements for the A050385 erratum
>   dpaa_eth: try to move the data in place for the A050385 erratum
> 
>  .../net/ethernet/freescale/dpaa/dpaa_eth.c    | 42 +++++++++++++++++--
>  1 file changed, 38 insertions(+), 4 deletions(-)
> 
> --
> 2.17.1

For the series,

Acked-by: Madalin Bucur <madalin.bucur@....nxp.com>