netdev - Re: [PATCH bpf] selftests/bpf: use bash instead of sh in test_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ+HfNgRQ1do=tXhHOia2KdQQ-08CYduXcgdvT6o1XcL--+_yA@mail.gmail.com>
Date:   Sat, 6 Feb 2021 08:46:55 +0100
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     William Tu <u9012063@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        Björn Töpel <bjorn.topel@...el.com>
Subject: Re: [PATCH bpf] selftests/bpf: use bash instead of sh in test_xdp_redirect.sh

On Fri, 5 Feb 2021 at 18:39, Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 2/5/21 9:30 AM, William Tu wrote:
> > On Fri, Feb 5, 2021 at 9:09 AM Björn Töpel <bjorn.topel@...il.com> wrote:
> >>
> >> From: Björn Töpel <bjorn.topel@...el.com>
> >>
> >> The test_xdp_redirect.sh script uses some bash-features, such as
> >> '&>'. On systems that use dash as the sh implementation this will not
> >> work as intended. Change the shebang to use bash instead.
>
> Hi,
> In general we (kernel, maybe not bpf) try to move away from bash to a more
> "standard" sh shell, so things like "&>" would be converted to ">file 2>&1"
> or whatever is needed.
>

Ok! I'll respin!

Björn