netdev - Re: [PATCH 1/1] ibmvnic: Clear failover

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210206103653.33671590@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 6 Feb 2021 10:36:53 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
Cc:     netdev@...r.kernel.org, Dany Madden <drt@...ux.ibm.com>,
        Lijun Pan <ljp@...ux.ibm.com>,
        Rick Lindsley <ricklind@...ux.ibm.com>, cforno12@...ux.ibm.com
Subject: Re: [PATCH 1/1] ibmvnic: Clear failover_pending if unable to
 schedule

On Tue,  2 Feb 2021 21:08:02 -0800 Sukadev Bhattiprolu wrote:
> Normally we clear the failover_pending flag when processing the reset.
> But if we are unable to schedule a failover reset we must clear the
> flag ourselves. We could fail to schedule the reset if we are in PROBING
> state (eg: when booting via kexec) or because we could not allocate memory.
> 
> Thanks to Cris Forno for helping isolate the problem and for testing.
> 
> Fixes: 1d8504937478 ("powerpc/vnic: Extend "failover pending" window")
> Signed-off-by: Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
> Tested-by: Cristobal Forno <cforno12@...ux.ibm.com>

Applied, thanks.

> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index df1b4884b4e8..58108e1a1d2e 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -4907,7 +4907,23 @@ static void ibmvnic_handle_crq(union ibmvnic_crq *crq,
>  				complete(&adapter->init_done);
>  				adapter->init_done_rc = -EIO;
>  			}
> -			ibmvnic_reset(adapter, VNIC_RESET_FAILOVER);
> +			rc = ibmvnic_reset(adapter, VNIC_RESET_FAILOVER);
> +			if (rc && rc != -EBUSY) {
> +				/**

I fixed this comment up for you - /** (double star) is reserved for
kdoc comments, normal comments should start with /*. And in networking
the first line of the multi-line comment is not empty.

> +				 * We were unable to schedule the failover