netdev - Re: [PATCH net 1/1] net: stmmac: set TxQ mode back to DCB after disabling CBS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8735yap2bi.fsf@vcostago-mobl2.amr.corp.intel.com>
Date:   Fri, 05 Feb 2021 14:38:57 -0800
From:   Vinicius Costa Gomes <vinicius.gomes@...el.com>
To:     Song Yoong Siang <yoong.siang.song@...el.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
Cc:     netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Ong Boon Leong <boon.leong.ong@...el.com>,
        Voon Wei Feng <weifeng.voon@...el.com>,
        Wong Vee Khee <vee.khee.wong@...el.com>,
        Song Yoong Siang <yoong.siang.song@...el.com>
Subject: Re: [PATCH net 1/1] net: stmmac: set TxQ mode back to DCB after
 disabling CBS

Song Yoong Siang <yoong.siang.song@...el.com> writes:

> From: Mohammad Athari Bin Ismail <mohammad.athari.ismail@...el.com>
>
> When disable CBS, mode_to_use parameter is not updated even the operation
> mode of Tx Queue is changed to Data Centre Bridging (DCB). Therefore,
> when tc_setup_cbs() function is called to re-enable CBS, the operation
> mode of Tx Queue remains at DCB, which causing CBS fails to work.
>
> This patch updates the value of mode_to_use parameter to MTL_QUEUE_DCB
> after operation mode of Tx Queue is changed to DCB in stmmac_dma_qmode()
> callback function.
>
> Fixes: 1f705bc61aee ("net: stmmac: Add support for CBS QDISC")
> Suggested-by: Gomes, Vinicius <vinicius.gomes@...el.com>

Just a nitpick/formality, I would prefer if you used:

Suggested-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>

> Signed-off-by: Mohammad Athari Bin Ismail <mohammad.athari.ismail@...el.com>
> Signed-off-by: Song, Yoong Siang <yoong.siang.song@...el.com>

Patch looks good.

Acked-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>

Cheers,
-- 
Vinicius