netdev - Re: [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1eae547-aa14-8307-cb81-b585a13bbd3d@infradead.org>
Date:   Fri, 5 Feb 2021 19:16:44 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Amy Parker <enbyamy@...il.com>, davem@...emloft.net,
        kuba@...nel.org, akpm@...ux-foundation.org, rppt@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide

On 2/5/21 4:01 PM, Amy Parker wrote:
> This patchset updates atarilance.c and sun3lance.c to follow the kernel
> style guide. Each patch tackles a different issue in the style guide.
> 
>    -Amy IP
> 
> Amy Parker (3):
>   drivers/net/ethernet/amd: Correct spacing around C keywords
>   drivers/net/ethernet/amd: Fix bracket matching and line levels
>   drivers/net/ethernet/amd: Break apart one-lined expressions
> 
>  drivers/net/ethernet/amd/atarilance.c | 64 ++++++++++++++-------------
>  drivers/net/ethernet/amd/sun3lance.c  | 64 +++++++++++++++------------
>  2 files changed, 69 insertions(+), 59 deletions(-)
> 

Hi Amy,

For each patch, can you confirm that the before & after binary files
are the same?  or if they are not the same, explain why not?

Just something that I have done in the past...

thanks.
-- 
~Randy