netdev - Re: [PATCH net-next v4 5/5] net: mhi: Add mbim proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210208131213.7a2bb081@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 8 Feb 2021 13:12:22 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     netdev@...r.kernel.org, bjorn@...k.no, dcbw@...hat.com,
        carl.yin@...ctel.com, mpearson@...ovo.com, cchen50@...ovo.com,
        jwjiang@...ovo.com, ivan.zhang@...ctel.com,
        naveen.kumar@...ctel.com, ivan.mikhanchuk@...ctel.com
Subject: Re: [PATCH net-next v4 5/5] net: mhi: Add mbim proto

On Mon,  8 Feb 2021 09:00:37 +0100 Loic Poulain wrote:
> MBIM has initially been specified by USB-IF for transporting data (IP)
> between a modem and a host over USB. However some modern modems also
> support MBIM over PCIe (via MHI). In the same way as QMAP(rmnet), it
> allows to aggregate IP packets and to perform context multiplexing.
> 
> This change adds minimal MBIM data transport support to MHI, allowing
> to support MBIM only modems. MBIM being based on USB NCM, it reuses
> and copy some helpers/functions from the USB stack (cdc-ncm, cdc-mbim).
> 
> Note that is a subset of the CDC-MBIM specification, supporting only
> transport of network data (IP), there is no support for DSS. Moreover
> the multi-session (for multi-pdn) is not supported in this initial
> version, but will be added latter, and aligned with the cdc-mbim
> solution (VLAN tags).
> 
> This code has been inspired from the mhi_mbim downstream implementation
> (Carl Yin <carl.yin@...ctel.com>).
> 
> Signed-off-by: Loic Poulain <loic.poulain@...aro.org>

Sparse says:

drivers/net/mhi/proto_mbim.c:159:41: warning: restricted __le32 degrades to integer