netdev - Re: [PATCH net-next] net: octeontx2: Fix the confusion in buffer alloc failure path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210208133909.74fe5ab5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 8 Feb 2021 13:39:09 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kevin Hao <haokexin@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Sunil Goutham <sgoutham@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        Subbaraya Sundeep <sbhatta@...vell.com>,
        hariprasad <hkelam@...vell.com>, netdev@...r.kernel.org,
        Pavel Machek <pavel@....cz>
Subject: Re: [PATCH net-next] net: octeontx2: Fix the confusion in buffer
 alloc failure path

On Mon,  8 Feb 2021 09:45:45 +0800 Kevin Hao wrote:
> @@ -1214,7 +1214,7 @@ int otx2_sq_aura_pool_init(struct otx2_nic *pfvf)
>  	struct otx2_snd_queue *sq;
>  	struct otx2_pool *pool;
>  	int err, ptr;
> -	s64 bufptr;
> +	dma_addr_t bufptr;

nit: please keep the variable declaration lines sorted longest to
     shortest.