netdev - Re: [PATCH net 1/2] bridge: mrp: Fix the usage of br_mrp_port_switchdev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <181e48b3-54a0-5256-86a2-1f0d45e4b2cc@prevas.dk>
Date:   Tue, 9 Feb 2021 08:37:31 +0100
From:   Rasmus Villemoes <rasmus.villemoes@...vas.dk>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>, jiri@...nulli.us,
        ivecera@...hat.com, davem@...emloft.net, kuba@...nel.org,
        roopa@...dia.com, nikolay@...dia.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net 1/2] bridge: mrp: Fix the usage of
 br_mrp_port_switchdev_set_state

On 06/02/2021 22.47, Horatiu Vultur wrote:
> The function br_mrp_port_switchdev_set_state was called both with MRP
> port state and STP port state, which is an issue because they don't
> match exactly.
> 
> Therefore, update the function to be used only with STP port state and
> use the id SWITCHDEV_ATTR_ID_PORT_STP_STATE.
> 
> The choice of using STP over MRP is that the drivers already implement
> SWITCHDEV_ATTR_ID_PORT_STP_STATE and already in SW we update the port
> STP state.
> 
> Fixes: 9a9f26e8f7ea30 ("bridge: mrp: Connect MRP API with the switchdev API")
> Fixes: fadd409136f0f2 ("bridge: switchdev: mrp: Implement MRP API for switchdev")
> Fixes: 2f1a11ae11d222 ("bridge: mrp: Add MRP interface.")
> Reported-by: Rasmus Villemoes <rasmus.villemoes@...vas.dk>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> ---

Tested-by: Rasmus Villemoes <rasmus.villemoes@...vas.dk>