netdev - Re: [PATCH net-next v2] cxgb4: collect serial config version from register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0Uc=48siEFQ0kEx9mCzriZ1Dd1OuYkUXFimHpgSbkSUUHg@mail.gmail.com>
Date:   Tue, 9 Feb 2021 07:43:46 -0800
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Cc:     Netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Raju Rangoju <rajur@...lsio.com>
Subject: Re: [PATCH net-next v2] cxgb4: collect serial config version from register

On Mon, Feb 8, 2021 at 10:10 PM Rahul Lakkireddy
<rahul.lakkireddy@...lsio.com> wrote:
>
> Collect serial config version information directly from an internal
> register, instead of explicitly resizing VPD.
>
> v2:
> - Add comments on info stored in PCIE_STATIC_SPARE2 register.
>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
> ---
>  .../net/ethernet/chelsio/cxgb4/cudbg_entity.h |  3 ---
>  .../net/ethernet/chelsio/cxgb4/cudbg_lib.c    | 24 +++----------------
>  drivers/net/ethernet/chelsio/cxgb4/t4_regs.h  |  6 +++++
>  3 files changed, 9 insertions(+), 24 deletions(-)
>

Looks good.

Reviewed-by: Alexander Duyck <alexanderduyck@...com>