netdev - Re: [PATCH v11 net-next 15/15] net: mvpp2: add TX FC firmware check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210209162855.GQ1463@shell.armlinux.org.uk>
Date:   Tue, 9 Feb 2021 16:28:56 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     stefanc@...vell.com
Cc:     netdev@...r.kernel.org, thomas.petazzoni@...tlin.com,
        davem@...emloft.net, nadavh@...vell.com, ymarkman@...vell.com,
        linux-kernel@...r.kernel.org, kuba@...nel.org, mw@...ihalf.com,
        andrew@...n.ch, atenart@...nel.org, devicetree@...r.kernel.org,
        robh+dt@...nel.org, sebastian.hesselbarth@...il.com,
        gregory.clement@...tlin.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v11 net-next 15/15] net: mvpp2: add TX FC firmware check

On Tue, Feb 09, 2021 at 10:42:31AM +0200, stefanc@...vell.com wrote:
>  	if (priv->global_tx_fc && priv->hw_version != MVPP21) {
> -		val = mvpp2_cm3_read(priv, MSS_FC_COM_REG);
> -		val |= FLOW_CONTROL_ENABLE_BIT;
> -		mvpp2_cm3_write(priv, MSS_FC_COM_REG, val);
> +		err = mvpp2_enable_global_fc(priv);
> +		if (err) {
> +			dev_warn(&pdev->dev, "CM3 firmware not running, version should be higher than 18.09 ");
> +			dev_warn(&pdev->dev, "and chip revision B0\n");
> +			dev_warn(&pdev->dev, "Flow control not supported\n");

I would much rather this was:

			dev_warn(&pdev->dev, "Minimum of CM3 firmware 18.09 and chip revision B0 required for flow control\n");

rather than trying to split it across several kernel messages.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!