netdev - Re: [Patch bpf-next 01/19] bpf: rename BPF_STREAM_PARSER to BPF_SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWJifJ0QGJ4F_B67KkuGTOwtzsLJYfMfqz48ZSmm1n9ZQ@mail.gmail.com>
Date:   Mon, 8 Feb 2021 17:40:10 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, duanxiongchun@...edance.com,
        Dongdong Wang <wangdongdong.6@...edance.com>,
        jiang.wang@...edance.com, Cong Wang <cong.wang@...edance.com>,
        John Fastabend <john.fastabend@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Lorenz Bauer <lmb@...udflare.com>
Subject: Re: [Patch bpf-next 01/19] bpf: rename BPF_STREAM_PARSER to BPF_SOCK_MAP

On Fri, Feb 5, 2021 at 2:32 AM Jakub Sitnicki <jakub@...udflare.com> wrote:
>
> On Wed, Feb 03, 2021 at 05:16 AM CET, Cong Wang wrote:
> > From: Cong Wang <cong.wang@...edance.com>
> >
> > Before we add non-TCP support, it is necessary to rename
> > BPF_STREAM_PARSER as it will be no longer specific to TCP,
> > and it does not have to be a parser either.
> >
> > This patch renames BPF_STREAM_PARSER to BPF_SOCK_MAP, so
> > that sock_map.c hopefully would be protocol-independent.
> >
> > Also, improve its Kconfig description to avoid confusion.
> >
> > Cc: John Fastabend <john.fastabend@...il.com>
> > Cc: Daniel Borkmann <daniel@...earbox.net>
> > Cc: Jakub Sitnicki <jakub@...udflare.com>
> > Cc: Lorenz Bauer <lmb@...udflare.com>
> > Signed-off-by: Cong Wang <cong.wang@...edance.com>
> > ---
> >  include/linux/bpf.h       |  4 ++--
> >  include/linux/bpf_types.h |  2 +-
> >  include/net/tcp.h         |  4 ++--
> >  include/net/udp.h         |  4 ++--
> >  net/Kconfig               | 13 ++++++-------
> >  net/core/Makefile         |  2 +-
> >  net/ipv4/Makefile         |  2 +-
> >  net/ipv4/tcp_bpf.c        |  4 ++--
> >  8 files changed, 17 insertions(+), 18 deletions(-)
>
> We also have a couple of references to CONFIG_BPF_STREAM_PARSER in
> tools/tests:
>
> $ git grep -i bpf_stream_parser
> ...
> tools/bpf/bpftool/feature.c:            { "CONFIG_BPF_STREAM_PARSER", },
> tools/testing/selftests/bpf/config:CONFIG_BPF_STREAM_PARSER=y

I think I did a grep in the whole tree, but still missed these two.

Thanks for catching it!