netdev - Re: [net-next V2 12/17] net/mlx5e: Extract tc tunnel encap/decap code to dedicated file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210209203543.GA171626@roeck-us.net>
Date:   Tue, 9 Feb 2021 12:35:43 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Vlad Buslov <vladbu@...dia.com>,
        Dmytro Linkin <dlinkin@...dia.com>,
        Roi Dayan <roid@...dia.com>, Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [net-next V2 12/17] net/mlx5e: Extract tc tunnel encap/decap
 code to dedicated file

On Fri, Feb 05, 2021 at 09:02:35PM -0800, Saeed Mahameed wrote:
> From: Vlad Buslov <vladbu@...dia.com>
> 
> Following patches in series extend the extracted code with routing
> infrastructure. To improve code modularity created a dedicated
> tc_tun_encap.c source file and move encap/decap related code to the new
> file. Export code that is used by both regular TC code and encap/decap code
> into tc_priv.h (new header intended to be used only by TC module). Rename
> some exported functions by adding "mlx5e_" prefix to their names.
> 
> Signed-off-by: Vlad Buslov <vladbu@...dia.com>
> Signed-off-by: Dmytro Linkin <dlinkin@...dia.com>
> Reviewed-by: Roi Dayan <roid@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>

When building s390:defconfig, this patch results in:

In file included from drivers/net/ethernet/mellanox/mlx5/core/en_tc.h:40,
                 from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:45:
drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.h:24:29: error: field 'match_level' has incomplete type

Bisect log attached.

Guenter

---
# bad: [a4bfd8d46ac357c12529e4eebb6c89502b03ecc9] Add linux-next specific files for 20210209
# good: [92bf22614b21a2706f4993b278017e437f7785b3] Linux 5.11-rc7
git bisect start 'HEAD' 'v5.11-rc7'
# bad: [a8eb921ba7e8e77d994a1c6c69c8ef08456ecf53] Merge remote-tracking branch 'crypto/master'
git bisect bad a8eb921ba7e8e77d994a1c6c69c8ef08456ecf53
# good: [b68df186dae8ae890df08059bb068b78252b053a] Merge remote-tracking branch 'hid/for-next'
git bisect good b68df186dae8ae890df08059bb068b78252b053a
# good: [1299616023a0db19be4ff5588db4fb61d8cd51f9] Merge tag 'mt76-for-kvalo-2021-01-29' of https://github.com/nbd168/wireless
git bisect good 1299616023a0db19be4ff5588db4fb61d8cd51f9
# good: [db9deabba7a9a6fded1aeda51dda1ce9b78f0711] Merge remote-tracking branch 'v4l-dvb-next/master'
git bisect good db9deabba7a9a6fded1aeda51dda1ce9b78f0711
# good: [ed19e2282476b1e0dc01c67fc19010ab791a7a46] Merge remote-tracking branch 'rdma/for-next'
git bisect good ed19e2282476b1e0dc01c67fc19010ab791a7a46
# bad: [ae3b49168f93b4432b852ca6f2f7323fead45e8d] Merge remote-tracking branch 'bluetooth/master'
git bisect bad ae3b49168f93b4432b852ca6f2f7323fead45e8d
# good: [215cb7d3823e798de327e3232e396434fab84f42] bpf/benchs/bench_ringbufs: Remove unneeded semicolon
git bisect good 215cb7d3823e798de327e3232e396434fab84f42
# good: [de71a6cb4bf24d8993b9ca90d1ddb131b60251a1] Bluetooth: btusb: Fix memory leak in btusb_mtk_wmt_recv
git bisect good de71a6cb4bf24d8993b9ca90d1ddb131b60251a1
# bad: [8914add2c9e5518f6a864936658bba5752510b39] net/mlx5e: Handle FIB events to update tunnel endpoint device
git bisect bad 8914add2c9e5518f6a864936658bba5752510b39
# good: [4ad9116c84ed3243f7b706f07646a995f3bca502] net/mlx5e: Remove redundant match on tunnel destination mac
git bisect good 4ad9116c84ed3243f7b706f07646a995f3bca502
# bad: [0d9f96471493d5483d116c137693f03604332a04] net/mlx5e: Extract tc tunnel encap/decap code to dedicated file
git bisect bad 0d9f96471493d5483d116c137693f03604332a04
# good: [48d216e5596a58e3cfa6d4548343f982c5921b79] net/mlx5e: Refactor reg_c1 usage
git bisect good 48d216e5596a58e3cfa6d4548343f982c5921b79
# good: [8e404fefa58b6138531e3d4b5647ee79f75ae9a8] net/mlx5e: Match recirculated packet miss in slow table using reg_c1
git bisect good 8e404fefa58b6138531e3d4b5647ee79f75ae9a8
# first bad commit: [0d9f96471493d5483d116c137693f03604332a04] net/mlx5e: Extract tc tunnel encap/decap code to dedicated file