netdev - Re: [PATCH net] net: watchdog: hold device global xmit lock during tx disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 09 Feb 2021 00:30:08 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Edwin Peer <edwin.peer@...adcom.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        andrew.gospodarek@...adcom.com, michael.chan@...adcom.com
Subject: Re: [PATCH net] net: watchdog: hold device global xmit lock during tx
 disable

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri,  5 Feb 2021 17:37:32 -0800 you wrote:
> Prevent netif_tx_disable() running concurrently with dev_watchdog() by
> taking the device global xmit lock. Otherwise, the recommended:
> 
> 	netif_carrier_off(dev);
> 	netif_tx_disable(dev);
> 
> driver shutdown sequence can happen after the watchdog has already
> checked carrier, resulting in possible false alarms. This is because
> netif_tx_lock() only sets the frozen bit without maintaining the locks
> on the individual queues.
> 
> [...]

Here is the summary with links:
  - [net] net: watchdog: hold device global xmit lock during tx disable
    https://git.kernel.org/netdev/net/c/3aa6bce9af0e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html