netdev - Re: [PATCH v5 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 9 Feb 2021 11:27:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jyoti Bhayana <jbhayana@...gle.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-media@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v5 1/1] iio/scmi: Adding support for IIO SCMI Based
 Sensors

Hi Jyoti,

I love your patch! Perhaps something to improve:

[auto build test WARNING on iio/togreg]
[also build test WARNING on linus/master sparc-next/master v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jyoti-Bhayana/Adding-support-for-IIO-SCMI-based-sensors/20210209-072954
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/90744ef17921050ddb26b5c750ba690a2e3e222e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jyoti-Bhayana/Adding-support-for-IIO-SCMI-based-sensors/20210209-072954
        git checkout 90744ef17921050ddb26b5c750ba690a2e3e222e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/iio/common/scmi_sensors/scmi_iio.c:537:17: warning: no previous prototype for 'scmi_alloc_iiodev' [-Wmissing-prototypes]
     537 | struct iio_dev *scmi_alloc_iiodev(struct device *dev,
         |                 ^~~~~~~~~~~~~~~~~


vim +/scmi_alloc_iiodev +537 drivers/iio/common/scmi_sensors/scmi_iio.c

   536	
 > 537	struct iio_dev *scmi_alloc_iiodev(struct device *dev,
   538					  struct scmi_handle *handle,
   539					  const struct scmi_sensor_info *sensor_info)
   540	{
   541		struct iio_chan_spec *iio_channels;
   542		struct scmi_iio_priv *sensor;
   543		enum iio_modifier modifier;
   544		enum iio_chan_type type;
   545		struct iio_dev *iiodev;
   546		int i, ret;
   547	
   548		iiodev = devm_iio_device_alloc(dev, sizeof(*sensor));
   549		if (!iiodev)
   550			return ERR_PTR(-ENOMEM);
   551	
   552		iiodev->modes = INDIO_DIRECT_MODE;
   553		iiodev->dev.parent = dev;
   554		sensor = iio_priv(iiodev);
   555		sensor->handle = handle;
   556		sensor->sensor_info = sensor_info;
   557		sensor->sensor_update_nb.notifier_call = scmi_iio_sensor_update_cb;
   558		sensor->indio_dev = iiodev;
   559	
   560		/* adding one additional channel for timestamp */
   561		iiodev->num_channels = sensor_info->num_axis + 1;
   562		iiodev->name = sensor_info->name;
   563		iiodev->info = &scmi_iio_info;
   564	
   565		iio_channels =
   566			devm_kzalloc(dev,
   567				     sizeof(*iio_channels) * (iiodev->num_channels),
   568				     GFP_KERNEL);
   569		if (!iio_channels)
   570			return ERR_PTR(-ENOMEM);
   571	
   572		scmi_iio_set_sampling_freq_avail(iiodev);
   573	
   574		for (i = 0; i < sensor_info->num_axis; i++) {
   575			ret = scmi_iio_get_chan_type(sensor_info->axis[i].type, &type);
   576			if (ret < 0)
   577				return ERR_PTR(ret);
   578	
   579			ret = scmi_iio_get_chan_modifier(sensor_info->axis[i].name,
   580							 &modifier);
   581			if (ret < 0)
   582				return ERR_PTR(ret);
   583	
   584			scmi_iio_set_data_channel(&iio_channels[i], type, modifier,
   585						  sensor_info->axis[i].id);
   586		}
   587	
   588		scmi_iio_set_timestamp_channel(&iio_channels[i], i);
   589		iiodev->channels = iio_channels;
   590		return iiodev;
   591	}
   592	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (76567 bytes)