netdev - RE: [PATCH net-next 1/9] lan78xx: add NAPI interface support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <004601d6ffc0$bbf46c90$33dd45b0$@pebblebay.com>
Date:   Wed, 10 Feb 2021 15:23:30 -0000
From:   "John Efstathiades" <john.efstathiades@...blebay.com>
To:     "'Andrew Lunn'" <andrew@...n.ch>
Cc:     <UNGLinuxDriver@...rochip.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <Woojung.Huh@...rochip.com>
Subject: RE: [PATCH net-next 1/9] lan78xx: add NAPI interface support

Apologies for taking a while to reply.

> This patch is big. Given your description, it sounds like it can be
> split up. That will make reviewing a lot easier.

The patch changes the way the driver works in a fundamental way so finding
ways to split out the modifications into self-contained parts might be
tricky. I need to discuss with colleagues on how to best do this.

If that's not possible or results in some ugly patches do you have any
suggestions how we can make it easier for reviewers to understand and review
the patch?

> It would also be nice to include in the 0/X patch some performance
> data.

Yes, I can do that.

Thanks for the other comments. I'll sort out the issues before preparing an
update but it will take a few weeks to re-test the driver and prepare a new
patch.

John