netdev - Re: [PATCH v18 5/7] clocksource: Add clocksource id for arm arch counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210210162214.2e68e0da@slackpad.fritz.box>
Date:   Wed, 10 Feb 2021 16:22:14 +0000
From:   Andre Przywara <andre.przywara@....com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     netdev@...r.kernel.org, yangbo.lu@....com, john.stultz@...aro.org,
        tglx@...utronix.de, pbonzini@...hat.com, seanjc@...gle.com,
        richardcochran@...il.com, Mark.Rutland@....com, will@...nel.org,
        suzuki.poulose@....com, steven.price@....com,
        lorenzo.pieralisi@....com, sudeep.holla@....com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        kvmarm@...ts.cs.columbia.edu, kvm@...r.kernel.org,
        Steve.Capper@....com, justin.he@....com, jianyong.wu@....com,
        kernel-team@...roid.com
Subject: Re: [PATCH v18 5/7] clocksource: Add clocksource id for arm arch
 counter

On Mon,  8 Feb 2021 13:40:27 +0000
Marc Zyngier <maz@...nel.org> wrote:

> From: Jianyong Wu <jianyong.wu@....com>
> 
> Add clocksource id to the ARM generic counter so that it can be easily
> identified from callers such as ptp_kvm.
> 
> Cc: Mark Rutland <mark.rutland@....com>
> Signed-off-by: Jianyong Wu <jianyong.wu@....com>
> Signed-off-by: Marc Zyngier <maz@...nel.org>
> Link: https://lore.kernel.org/r/20201209060932.212364-6-jianyong.wu@arm.com

Reviewed-by: Andre Przywara <andre.przywara@....com>

Cheers,
Andre

> ---
>  drivers/clocksource/arm_arch_timer.c | 2 ++
>  include/linux/clocksource_ids.h      | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index d0177824c518..8f12e223703f 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -16,6 +16,7 @@
>  #include <linux/cpu_pm.h>
>  #include <linux/clockchips.h>
>  #include <linux/clocksource.h>
> +#include <linux/clocksource_ids.h>
>  #include <linux/interrupt.h>
>  #include <linux/of_irq.h>
>  #include <linux/of_address.h>
> @@ -191,6 +192,7 @@ static u64 arch_counter_read_cc(const struct cyclecounter *cc)
>  
>  static struct clocksource clocksource_counter = {
>  	.name	= "arch_sys_counter",
> +	.id	= CSID_ARM_ARCH_COUNTER,
>  	.rating	= 400,
>  	.read	= arch_counter_read,
>  	.mask	= CLOCKSOURCE_MASK(56),
> diff --git a/include/linux/clocksource_ids.h b/include/linux/clocksource_ids.h
> index 4d8e19e05328..16775d7d8f8d 100644
> --- a/include/linux/clocksource_ids.h
> +++ b/include/linux/clocksource_ids.h
> @@ -5,6 +5,7 @@
>  /* Enum to give clocksources a unique identifier */
>  enum clocksource_ids {
>  	CSID_GENERIC		= 0,
> +	CSID_ARM_ARCH_COUNTER,
>  	CSID_MAX,
>  };
>