netdev - Re: [PATCH RFC/RFT 0/2] W=1 by default for Ethernet PHY subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210210185534.GF4247@nvidia.com>
Date:   Wed, 10 Feb 2021 14:55:34 -0400
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Andrew Lunn <andrew@...n.ch>,
        Nathan Chancellor <nathan@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>
Subject: Re: [PATCH RFC/RFT 0/2] W=1 by default for Ethernet PHY subsystem

On Wed, Feb 10, 2021 at 10:43:29AM -0800, Jakub Kicinski wrote:
> On Wed, 10 Feb 2021 14:39:17 -0400 Jason Gunthorpe wrote:
> > On Sun, Sep 20, 2020 at 04:53:51PM +0200, Andrew Lunn wrote:
> > 
> > > How often are new W=1 flags added? My patch exported
> > > KBUILD_CFLAGS_WARN1. How about instead we export
> > > KBUILD_CFLAGS_WARN1_20200920. A subsystem can then sign up to being
> > > W=1 clean as for the 20200920 definition of W=1.  
> > 
> > I think this is a reasonable idea.
> > 
> > I'm hitting exactly the issue this series is trying to solve, Lee
> > invested a lot of effort to make drivers/infiniband/ W=1 clean, but
> > as maintainer I can't sustain this since there is no easy way to have
> > a warning free compile and get all extra warnings.  Also all my
> > submitters are not running with W=1
> > 
> > I need kbuild to get everyone on the same page to be able to sustain
> > the warning clean up. We've already had a regression and it has only
> > been a few weeks :(
> 
> Do you use patchwork? A little bit of automation is all you need,
> really. kbuild bot is too slow, anyway.

Yes, I bookmarked your automation scripts, but getting it all setup
for the first time seems like a big mountain to climb..

I already do compile almost every patch, the problem is there is no
easy way to get W=1 set for just a subset of files and still compile
each file only once.

If this makefile change was done then my submitters would see the
warning even before posting a patch. It is already quite rare I see
patches with compile warnings by the time they get to me. Even
unlikable checkpatch warnings have been fairly low..

Jason