netdev - Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Feb 2021 11:50:42 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Hariprasad Kelam <hkelam@...vell.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        "Geethasowjanya Akula" <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
Subject: Re: [Patch v4 net-next 0/7] ethtool support for fec and link
 configuration

On Wed, 10 Feb 2021 17:06:29 +0000 Hariprasad Kelam wrote:
> > On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote:  
> > > v4:
> > > 	- Corrected indentation issues
> > > 	- Use FEC_OFF if user requests for FEC_AUTO mode
> > > 	- Do not clear fec stats in case of user changes
> > > 	  fec mode
> > > 	- dont hide fec stats depending on interface mode
> > > 	  selection  
> > 
> > What about making autoneg modes symmetric between set and get?  
> 
> Get supports multi modes such that user can select one of the modes
> to advertise. For time being set only supports single mode. Do let me
> know if you want me to Add this in commit description.

You use the same code for supported and advertising.
Please add a check that there is only one advertising mode 
reported so we don't have to take your word for it.

Thanks.