netdev - Re: [PATCH v4 net-next 06/11] skbuff: remove __kfree_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Feb 2021 04:22:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Alexander Lobakin <alobakin@...me>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Alexander Lobakin <alobakin@...me>,
        Randy Dunlap <rdunlap@...radead.org>,
        Kevin Hao <haokexin@...il.com>
Subject: Re: [PATCH v4 net-next 06/11] skbuff: remove __kfree_skb_flush()

Hi Alexander,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Alexander-Lobakin/skbuff-introduce-skbuff_heads-bulking-and-reusing/20210211-004041
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git de1db4a6ed6241e34cab0e5059d4b56f6bae39b9
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6bb224307d9f31afa154a8825f9acbd8e9f6b490
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alexander-Lobakin/skbuff-introduce-skbuff_heads-bulking-and-reusing/20210211-004041
        git checkout 6bb224307d9f31afa154a8825f9acbd8e9f6b490
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   net/core/dev.c: In function 'napi_threaded_poll':
>> net/core/dev.c:7012:4: error: implicit declaration of function '__kfree_skb_flush'; did you mean '__kfree_skb_defer'? [-Werror=implicit-function-declaration]
    7012 |    __kfree_skb_flush();
         |    ^~~~~~~~~~~~~~~~~
         |    __kfree_skb_defer
   cc1: some warnings being treated as errors

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +7012 net/core/dev.c

29863d41bb6e1d Wei Wang 2021-02-08  6996  
29863d41bb6e1d Wei Wang 2021-02-08  6997  static int napi_threaded_poll(void *data)
29863d41bb6e1d Wei Wang 2021-02-08  6998  {
29863d41bb6e1d Wei Wang 2021-02-08  6999  	struct napi_struct *napi = data;
29863d41bb6e1d Wei Wang 2021-02-08  7000  	void *have;
29863d41bb6e1d Wei Wang 2021-02-08  7001  
29863d41bb6e1d Wei Wang 2021-02-08  7002  	while (!napi_thread_wait(napi)) {
29863d41bb6e1d Wei Wang 2021-02-08  7003  		for (;;) {
29863d41bb6e1d Wei Wang 2021-02-08  7004  			bool repoll = false;
29863d41bb6e1d Wei Wang 2021-02-08  7005  
29863d41bb6e1d Wei Wang 2021-02-08  7006  			local_bh_disable();
29863d41bb6e1d Wei Wang 2021-02-08  7007  
29863d41bb6e1d Wei Wang 2021-02-08  7008  			have = netpoll_poll_lock(napi);
29863d41bb6e1d Wei Wang 2021-02-08  7009  			__napi_poll(napi, &repoll);
29863d41bb6e1d Wei Wang 2021-02-08  7010  			netpoll_poll_unlock(have);
29863d41bb6e1d Wei Wang 2021-02-08  7011  
29863d41bb6e1d Wei Wang 2021-02-08 @7012  			__kfree_skb_flush();
29863d41bb6e1d Wei Wang 2021-02-08  7013  			local_bh_enable();
29863d41bb6e1d Wei Wang 2021-02-08  7014  
29863d41bb6e1d Wei Wang 2021-02-08  7015  			if (!repoll)
29863d41bb6e1d Wei Wang 2021-02-08  7016  				break;
29863d41bb6e1d Wei Wang 2021-02-08  7017  
29863d41bb6e1d Wei Wang 2021-02-08  7018  			cond_resched();
29863d41bb6e1d Wei Wang 2021-02-08  7019  		}
29863d41bb6e1d Wei Wang 2021-02-08  7020  	}
29863d41bb6e1d Wei Wang 2021-02-08  7021  	return 0;
29863d41bb6e1d Wei Wang 2021-02-08  7022  }
29863d41bb6e1d Wei Wang 2021-02-08  7023  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (54007 bytes)