netdev - RE: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5d7ccb5804b46eea2ef9fe29c66720f@intel.com>
Date:   Wed, 10 Feb 2021 01:46:46 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Punit Agrawal <punit1.agrawal@...hiba.co.jp>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "daichi1.fukui@...hiba.co.jp" <daichi1.fukui@...hiba.co.jp>,
        "nobuhiro1.iwamatsu@...hiba.co.jp" <nobuhiro1.iwamatsu@...hiba.co.jp>,
        Corinna Vinschen <vinschen@...hat.com>,
        "Brown, Aaron F" <aaron.f.brown@...el.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: RE: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS
 WRAP" log message



> -----Original Message-----
> From: Punit Agrawal <punit1.agrawal@...hiba.co.jp>
> Sent: Tuesday, February 09, 2021 5:35 PM
> To: netdev@...r.kernel.org
> Cc: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; daichi1.fukui@...hiba.co.jp;
> nobuhiro1.iwamatsu@...hiba.co.jp; Corinna Vinschen <vinschen@...hat.com>;
> Keller, Jacob E <jacob.e.keller@...el.com>; Brown, Aaron F
> <aaron.f.brown@...el.com>; Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Subject: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log
> message
> 
> From: Corinna Vinschen <vinschen@...hat.com>
> 
> commit 2643e6e90210e16c978919617170089b7c2164f7 upstream
> 
> TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP
> every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000
> secs on 80576 (45 bit SYSTIM).
> 
> This wrap event sets the TSICR.SysWrap bit unconditionally.
> 
> However, checking TSIM at interrupt time shows that this event does not
> actually cause the interrupt.  Rather, it's just bycatch while the
> actual interrupt is caused by, for instance, TSICR.TXTS.
> 
> The conclusion is that the SYS WRAP is actually expected, so the
> "unexpected SYS WRAP" message is entirely bogus and just helps to
> confuse users.  Drop it.
> 
> Signed-off-by: Corinna Vinschen <vinschen@...hat.com>
> Acked-by: Jacob Keller <jacob.e.keller@...el.com>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
> Hi,
> 
> A customer reported that the following message appears in the kernel
> logs every 1100s -
> 
>     igb 0000:01:00.1: unexpected SYS WRAP
> 
> As the systems have large uptimes the messages are crowding the logs.
> 
> The message was dropped in
> commit 2643e6e90210e16c ("igb: Remove incorrect "unexpected SYS WRAP" log
> message")
> in v4.14.
> 
> Please consider applying to patch to v4.4 and v4.9 stable kernels - it
> applies cleanly to both the trees.
> 
> Thanks,
> Punit
> 

It makes sense to me for htis to apply to those stable trees as well.

Thanks,
Jake