netdev - Re: [PATCH V2 net-next 1/2] dt-bindings: net: document BCM4908 Ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a22b4a6b-8712-f074-5168-f0800e6fa489@milecki.pl>
Date:   Tue, 9 Feb 2021 23:07:11 +0100
From:   Rafał Miłecki <rafal@...ecki.pl>
To:     Rob Herring <robh@...nel.org>,
        Rafał Miłecki <zajec5@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Masahiro Yamada <masahiroy@...nel.org>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH V2 net-next 1/2] dt-bindings: net: document BCM4908
 Ethernet controller

On 09.02.2021 22:43, Rob Herring wrote:
> On Sun, Feb 07, 2021 at 11:26:31PM +0100, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@...ecki.pl>
>>
>> BCM4908 is a family of SoCs with integrated Ethernet controller.
>>
>> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
>> ---
>>   .../bindings/net/brcm,bcm4908enet.yaml        | 45 +++++++++++++++++++
>>   1 file changed, 45 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/net/brcm,bcm4908enet.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/net/brcm,bcm4908enet.yaml b/Documentation/devicetree/bindings/net/brcm,bcm4908enet.yaml
>> new file mode 100644
>> index 000000000000..5f12f51c5b19
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/brcm,bcm4908enet.yaml
>> @@ -0,0 +1,45 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/net/brcm,bcm4908enet.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Broadcom BCM4908 Ethernet controller
>> +
>> +description: Broadcom's Ethernet controller integrated into BCM4908 family SoCs
>> +
>> +maintainers:
>> +  - Rafał Miłecki <rafal@...ecki.pl>
>> +
> 
> allOf:
>    - $ref: 'ethernet-controller.yaml#'

Thanks!


>> +properties:
>> +  compatible:
>> +    const: brcm,bcm4908enet
> 
> Normal convention is 'brcm,bcm4908-enet'. (And update the filename/$id)

Is it? ;) It seems we have:
brcm,bcmgenet (not brcm,bcmg-enet)
fsl-enetc (not e.g. fsl-enet-c)
xilinx_axienet (not xilinx_axi-enet)
apm,xgene1-sgenet (not apm,xgene1-sg-enet)

Of course, as you seem to prefer *-enet, I'll make it so! V3 soon.


>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    description: RX interrupt
>> +
>> +  interrupt-names:
>> +    const: rx
> 
> Don't really need *-names when only 1 possible entry.

I think this controller may have some more interrupts (I don't know about). We can "interrupt-names" later, when we find them out.