netdev - RE: [EXT] Re: [PATCH v13 net-next 13/15] net: mvpp2: add PPv23 RX FIFO flow control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO6PR18MB3873E18A4761D8DCB6D4300FB08C9@CO6PR18MB3873.namprd18.prod.outlook.com>
Date:   Thu, 11 Feb 2021 13:06:41 +0000
From:   Stefan Chulski <stefanc@...vell.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Nadav Haklai <nadavh@...vell.com>,
        Yan Markman <ymarkman@...vell.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "mw@...ihalf.com" <mw@...ihalf.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "atenart@...nel.org" <atenart@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>,
        "gregory.clement@...tlin.com" <gregory.clement@...tlin.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [EXT] Re: [PATCH v13 net-next 13/15] net: mvpp2: add PPv23 RX
 FIFO flow control


> > +/* Configure Rx FIFO Flow control thresholds */ void
> > +mvpp23_rx_fifo_fc_en(struct mvpp2 *priv, int port, bool en) {
> > +	int val;
> 
> 	u32 ?

OK.

> > +
> > +	val = mvpp2_read(priv, MVPP2_RX_FC_REG(port));
> > +
> > +	if (en)
> > +		val |= MVPP2_RX_FC_EN;
> > +	else
> > +		val &= ~MVPP2_RX_FC_EN;
> > +
> > +	mvpp2_write(priv, MVPP2_RX_FC_REG(port), val);
> 
> 	if (en)
> 		val = MVPP2_RX_FC_EN;
> 	else
> 		val = 0;
> 
> 	mvpp2_modify(priv + MVPP2_RX_FC_REG(port),
> MVPP2_RX_FC_EN, val);
> 
> ?

OK, I would use mvpp2_modify Here.

Thanks,
Stefan.