netdev - Re: [PATCH v1 0/7] Add support for IPA v3.1, GSI v1.0, MSM8998 IPA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f30c9f66-8284-0ada-3586-edf75fce12f7@somainline.org>
Date:   Thu, 11 Feb 2021 22:51:07 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>
To:     Alex Elder <elder@...e.org>, elder@...nel.org
Cc:     bjorn.andersson@...aro.org, agross@...nel.org, davem@...emloft.net,
        kuba@...nel.org, linux-arm-msm@...r.kernel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, konrad.dybcio@...ainline.org,
        marijn.suijten@...ainline.org, phone-devel@...r.kernel.org
Subject: Re: [PATCH v1 0/7] Add support for IPA v3.1, GSI v1.0, MSM8998 IPA

Il 11/02/21 21:27, Alex Elder ha scritto:
> On 2/11/21 11:50 AM, AngeloGioacchino Del Regno wrote:
>> Hey all!
>>
>> This time around I thought that it would be nice to get some modem
>> action going on. We have it, it's working (ish), so just.. why not.
> 
> Thank you for the patches!
> 
> I would like to review these carefully but I'm sorry
> I won't be able to get to it today, and possibly not
> for a few days.  But I *will* review them.
> 

Don't worry :))

> I just want you to know I'm paying attention, though
> I'm sort of buried in an important issue right now.
> 
> I'm very impressed at how small the patches are though.

Actually, the driver is in a great shape. That's why the patches are
that small: thanks to you!

-- Angelo

> 
>                      -Alex
> 
>> This series adds support for IPA v3.1 (featuring GSI v1.0) and also
>> takes account for some bits that are shared with other unimplemented
>> IPA v3 variants and it is specifically targeting MSM8998, for which
>> support is added.
>>
>> Since the userspace isn't entirely ready (as far as I can see) for
>> data connection (3g/lte/whatever) through the modem, it was possible
>> to only partially test this series.
>> Specifically, loading the IPA firmware and setting up the interface
>> went just fine, along with a basic setup of the network interface
>> that got exposed by this driver.
>>
>> With this series, the benefits that I see are:
>>   1. The modem doesn't crash anymore when trying to setup a data
>>      connection, as now the modem firmware seems to be happy with
>>      having IPA initialized and ready;
>>   2. Other random modem crashes while picking up LTE home network
>>      signal (even just for calling, nothing fancy) seem to be gone.
>>
>> These are the reasons why I think that this series is ready for
>> upstream action. It's *at least* stabilizing the platform when
>> the modem is up.
>>
>> This was tested on the F(x)Tec Pro 1 (MSM8998) smartphone.
>>
>> AngeloGioacchino Del Regno (7):
>>    net: ipa: Add support for IPA v3.1 with GSI v1.0
>>    net: ipa: endpoint: Don't read unexistant register on IPAv3.1
>>    net: ipa: gsi: Avoid some writes during irq setup for older IPA
>>    net: ipa: gsi: Use right masks for GSI v1.0 channels hw param
>>    net: ipa: Add support for IPA on MSM8998
>>    dt-bindings: net: qcom-ipa: Document qcom,sc7180-ipa compatible
>>    dt-bindings: net: qcom-ipa: Document qcom,msm8998-ipa compatible
>>
>>   .../devicetree/bindings/net/qcom,ipa.yaml     |   7 +-
>>   drivers/net/ipa/Makefile                      |   3 +-
>>   drivers/net/ipa/gsi.c                         |  33 +-
>>   drivers/net/ipa/gsi_reg.h                     |   5 +
>>   drivers/net/ipa/ipa_data-msm8998.c            | 407 ++++++++++++++++++
>>   drivers/net/ipa/ipa_data.h                    |   5 +
>>   drivers/net/ipa/ipa_endpoint.c                |  26 +-
>>   drivers/net/ipa/ipa_main.c                    |  12 +-
>>   drivers/net/ipa/ipa_reg.h                     |   3 +
>>   drivers/net/ipa/ipa_version.h                 |   1 +
>>   10 files changed, 480 insertions(+), 22 deletions(-)
>>   create mode 100644 drivers/net/ipa/ipa_data-msm8998.c
>>
>