netdev - [PATCH iproute2 4/6] man8/bridge.8: fix which one of self/master is default for "bridge fdb"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210211104502.2081443-5-olteanv@gmail.com>
Date:   Thu, 11 Feb 2021 12:45:00 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Ido Schimmel <idosch@...sch.org>,
        DENG Qingfang <dqfext@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: [PATCH iproute2 4/6] man8/bridge.8: fix which one of self/master is default for "bridge fdb"

From: Vladimir Oltean <vladimir.oltean@....com>

The bridge program does:

fdb_modify:
	/* Assume self */
	if (!(req.ndm.ndm_flags&(NTF_SELF|NTF_MASTER)))
		req.ndm.ndm_flags |= NTF_SELF;

which is clearly against the documented behavior. The only thing we can
do, sadly, is update the documentation.

Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
---
 man/man8/bridge.8 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
index b629c52b8341..1dc0aec83f09 100644
--- a/man/man8/bridge.8
+++ b/man/man8/bridge.8
@@ -533,11 +533,12 @@ specified.
 .sp
 
 .B self
-- the address is associated with the port drivers fdb. Usually hardware.
+- the address is associated with the port drivers fdb. Usually hardware
+  (default).
 .sp
 
 .B master
-- the address is associated with master devices fdb. Usually software (default).
+- the address is associated with master devices fdb. Usually software.
 .sp
 
 .B router
-- 
2.25.1