netdev - Re: [PATCH bpf] devmap: Use GFP_KERNEL for xdp bulk queue allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0692ede4-1f1e-2a19-db02-024c47f93202@iogearbox.net>
Date:   Sat, 13 Feb 2021 00:17:38 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     NOMURA JUNICHI(野村　淳一) 
        <junichi.nomura@....com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "ast@...nel.org" <ast@...nel.org>,
        "toke@...hat.com" <toke@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf] devmap: Use GFP_KERNEL for xdp bulk queue allocation

On 2/9/21 9:24 AM, NOMURA JUNICHI(野村　淳一) wrote:
> The devmap bulk queue is allocated with GFP_ATOMIC and the allocation may
> fail if there is no available space in existing percpu pool.
> 
> Since commit 75ccae62cb8d42 ("xdp: Move devmap bulk queue into struct net_device")
> moved the bulk queue allocation to NETDEV_REGISTER callback, whose context
> is allowed to sleep, use GFP_KERNEL instead of GFP_ATOMIC to let percpu
> allocator extend the pool when needed and avoid possible failure of netdev
> registration.
> 
> As the required alignment is natural, we can simply use alloc_percpu().
> 
> Signed-off-by: Jun'ichi Nomura <junichi.nomura@....com>

Applied, thanks!