netdev - Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Feb 2021 09:29:47 +0900
From:   Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>
To:     David Miller <davem@...emloft.net>
Cc:     kuba@...nel.org, robh+dt@...nel.org, peppe.cavallaro@...com,
        alexandre.torgue@...com, joabreu@...opsys.com,
        punit1.agrawal@...hiba.co.jp, yuji2.ishikawa@...hiba.co.jp,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

Hi,

Thanks for your comment.

On Thu, Feb 11, 2021 at 02:13:07PM -0800, David Miller wrote:
> From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>
> Date: Thu, 11 Feb 2021 01:29:52 +0900
> 
> > +static int visconti_eth_init_hw(struct platform_device *pdev, struct plat_stmmacenet_data *plat_dat)
> > +{
> > +	struct visconti_eth *dwmac;
> > +	unsigned int reg_val, clk_sel_val;
> 
> Please use reverse christmas tree ordering for local variable declarations.
> 
> > +static int visconti_eth_clock_probe(struct platform_device *pdev,
> > +				    struct plat_stmmacenet_data *plat_dat)
> > +{
> > +	int err;
> > +	struct visconti_eth *dwmac;
> 
> Likewise.
> 
> > +static int visconti_eth_clock_remove(struct platform_device *pdev)
> > +{
> > +	struct net_device *ndev = platform_get_drvdata(pdev);
> > +	struct stmmac_priv *priv = netdev_priv(ndev);
> > +	struct visconti_eth *dwmac = get_stmmac_bsp_priv(&pdev->dev);
> Likewise.
> 

OK, I will fix these.

Best regards,
  Nobuhiro