netdev - Re: [PATCH v2 net-next 07/12] net: mscc: ocelot: use common tag parsing code with DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Feb 2021 17:25:47 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Richard Cochran <richardcochran@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Maxim Kochetkov <fido_max@...ox.ru>,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v2 net-next 07/12] net: mscc: ocelot: use common tag
 parsing code with DSA



On 2/13/2021 14:37, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> The Injection Frame Header and Extraction Frame Header that the switch
> prepends to frames over the NPI port is also prepended to frames
> delivered over the CPU port module's queues.
> 
> Let's unify the handling of the frame headers by making the ocelot
> driver call some helpers exported by the DSA tagger. Among other things,
> this allows us to get rid of the strange cpu_to_be32 when transmitting
> the Injection Frame Header on ocelot, since the packing API uses
> network byte order natively (when "quirks" is 0).
> 
> The comments above ocelot_gen_ifh talk about setting pop_cnt to 3, and
> the cpu extraction queue mask to something, but the code doesn't do it,
> so we don't do it either.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian