netdev - Re: [PATCH iproute2-next] ss: Make leading ":" always optional for sport and dport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e45b850-6c2a-4089-1369-151987983552@gmail.com>
Date:   Sat, 13 Feb 2021 17:52:43 -0700
From:   David Ahern <dsahern@...il.com>
To:     Thayne McCombs <astrothayne@...il.com>, netdev@...r.kernel.org,
        dsahern@...nel.org
Subject: Re: [PATCH iproute2-next] ss: Make leading ":" always optional for
 sport and dport

On 2/5/21 11:36 PM, Thayne McCombs wrote:
> The sport and dport conditions in expressions were inconsistent on
> whether there should be a ":" at the beginning of the port when only a
> port was provided depending on the family. The link and netlink
> families required a ":" to work. The vsock family required the ":"
> to be absent. The inet and inet6 families work with or without a leading
> ":".
> 
> This makes the leading ":" optional in all cases, so if sport or dport
> are used, then it works with a leading ":" or without one, as inet and
> inet6 did.
> ---
>  misc/ss.c | 46 ++++++++++++++++++++++++----------------------
>  1 file changed, 24 insertions(+), 22 deletions(-)
> 

change looks fine, but you are missing a sign off.