netdev - RE: [EXT] Re: Phylink flow control support on ports with MLO_AN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO6PR18MB38730030DB698C57A8FDCC32B0899@CO6PR18MB3873.namprd18.prod.outlook.com>
Date:   Sun, 14 Feb 2021 09:33:16 +0000
From:   Stefan Chulski <stefanc@...vell.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
CC:     "andrew@...n.ch" <andrew@...n.ch>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Marcin Wojtas (mw@...ihalf.com)" <mw@...ihalf.com>,
        Nadav Haklai <nadavh@...vell.com>,
        "Yan Markman" <ymarkman@...vell.com>
Subject: RE: [EXT] Re: Phylink flow control support on ports with MLO_AN_FIXED
 auto negotiation

> > On Sun, Jan 31, 2021 at 11:12:14AM +0000, Russell King - ARM Linux admin
> wrote:
> > > I discussed it with Andrew earlier last year, and his response was:
> > >
> > >  DT configuration of pause for fixed link probably is sufficient. I
> > > don't  remember it ever been really discussed for DSA. It was a
> > > Melanox  discussion about limiting pause for the CPU. So I think it
> > > is safe to  not implement ethtool -A, at least until somebody has a
> > > real use case  for it.
> > >
> > > So I chose not to support it - no point supporting features that
> > > people aren't using. If you have a "real use case" then it can be added.
> >
> > This patch may be sufficient - I haven't fully considered all the
> > implications of changing this though.
> 
> Did you try this patch? What's the outcome?
> 

Hi,

Didn't tried it yet, its in my TODO list.

Regards,
Stefan.