netdev - Re: [PATCH net-next 0/4] Software fallback for bridging in DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210214162822.opken4nrk5hthlri@skbuf>
Date:   Sun, 14 Feb 2021 18:28:22 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com, Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        George McCollister <george.mccollister@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        DENG Qingfang <dqfext@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Rasmus Villemoes <rasmus.villemoes@...vas.dk>,
        Oleksij Rempel <linux@...pel-privat.de>
Subject: Re: [PATCH net-next 0/4] Software fallback for bridging in DSA

On Sun, Feb 14, 2021 at 05:53:22PM +0200, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> As was discussed here:
> https://patchwork.kernel.org/project/netdevbpf/patch/20201202091356.24075-3-tobias@waldekranz.com/
> 
> it is desirable to not reject a LAG interface (bonding, team) even if
> the switch isn't able to offload bridging towards that link aggregation
> group. At least the DSA setups I have are not that unbalanced between
> the horsepower of the CPU and the horsepower of the switch such that
> software forwarding to be completely impractical.
> 
> This series makes all switch drivers theoretically able to do the right
> thing when they are configured in a way similar to this (credits to
> Tobias Waldekranz for the drawing):
> 
>       br0
>      /   \
>   team0   \
>    / \     \
> swp0 swp1  swp2
> 
> although in practice there is one more prerequisite: for software
> fallback mode, they need to disable address learning. It is preferable
> that they do this by implementing the .port_pre_bridge_join and
> .port_bridge_join methods.

Sadly there is some false marketing on my part here and this series is
probably not enough for the above configuration to work in software.
I have to confess that I tested with software bridging, and with
software LAG, but not with both at the same time. I sent this series way
too quickly and I should probably spend more time on it. Sorry to
everyone copied for the noise.