lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 13 Feb 2021 17:06:22 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Vladimir Oltean <olteanv@...il.com>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org Cc: Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Kurt Kanzenbach <kurt@...utronix.de>, Woojung Huh <woojung.huh@...rochip.com>, Linus Walleij <linus.walleij@...aro.org>, Hauke Mehrtens <hauke@...ke-m.de>, Jiri Pirko <jiri@...nulli.us>, Ivan Vecera <ivecera@...hat.com>, Roopa Prabhu <roopa@...dia.com>, Nikolay Aleksandrov <nikolay@...dia.com>, DENG Qingfang <dqfext@...il.com>, Ido Schimmel <idosch@...sch.org> Subject: Re: [PATCH net-next 2/5] net: bridge: propagate extack through store_bridge_parm On 2/13/2021 12:43, Vladimir Oltean wrote: > From: Vladimir Oltean <vladimir.oltean@....com> > > The bridge sysfs interface stores parameters for the STP, VLAN, > multicast etc subsystems using a predefined function prototype. > Sometimes the underlying function being called supports a netlink > extended ack message, and we ignore it. > > Let's expand the store_bridge_parm function prototype to include the > extack, and just print it to console, but at least propagate it where > applicable. Where not applicable, create a shim function in the > br_sysfs_br.c file that discards the extra function argument. > > This patch allows us to propagate the extack argument to > br_vlan_set_default_pvid, br_vlan_set_proto and br_vlan_filter_toggle, > and from there, further up in br_changelink from br_netlink.c. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists