netdev - Re: [PATCH] ss: Make leading ":" always optional for sport and dport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 14 Feb 2021 22:13:06 -0700
From:   David Ahern <dsahern@...il.com>
To:     Thayne McCombs <astrothayne@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] ss: Make leading ":" always optional for sport and dport

On 2/14/21 1:09 AM, Thayne McCombs wrote:
> Doh! Sorry about that, here it is with the sign-off.
> 
> -- >8 --

Don't put text here.

> 
> The sport and dport conditions in expressions were inconsistent on
> whether there should be a ":" at the beginning of the port when only a
> port was provided depending on the family. The link and netlink
> families required a ":" to work. The vsock family required the ":"
> to be absent. The inet and inet6 families work with or without a leading
> ":".
> 
> This makes the leading ":" optional in all cases, so if sport or dport
> are used, then it works with a leading ":" or without one, as inet and
> inet6 did.
> 
> Signed-off-by: Thayne McCombs <astrothayne@...il.com>
> ---

put extra comments here

>  misc/ss.c | 46 ++++++++++++++++++++++++----------------------
>  1 file changed, 24 insertions(+), 22 deletions(-)
> 

Also, put iproute2-next in the subject line along with a version number.

applied to iproute2-next.