netdev - Re: [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210215130003.GL2087@kadam>
Date:   Mon, 15 Feb 2021 16:00:04 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     kbuild@...ts.01.org, Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     lkp@...el.com, kbuild-all@...ts.01.org,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Richard Cochran <richardcochran@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate
 tagger for Seville

Hi Vladimir,

url:    https://github.com/0day-ci/linux/commits/Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3c5a2fd042d0bfac71a2dfb99515723d318df47b
config: i386-randconfig-m031-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...cle.com>

smatch warnings:
net/dsa/tag_ocelot.c:59 ocelot_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type?
net/dsa/tag_ocelot.c:71 seville_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type?

vim +59 net/dsa/tag_ocelot.c

9d88a16c0fc930 Vladimir Oltean 2021-02-13  52  static struct sk_buff *ocelot_xmit(struct sk_buff *skb,
9d88a16c0fc930 Vladimir Oltean 2021-02-13  53  				   struct net_device *netdev)
9d88a16c0fc930 Vladimir Oltean 2021-02-13  54  {
9d88a16c0fc930 Vladimir Oltean 2021-02-13  55  	struct dsa_port *dp = dsa_slave_to_port(netdev);
9d88a16c0fc930 Vladimir Oltean 2021-02-13  56  	void *injection;
9d88a16c0fc930 Vladimir Oltean 2021-02-13  57  
9d88a16c0fc930 Vladimir Oltean 2021-02-13  58  	ocelot_xmit_common(skb, netdev, cpu_to_be32(0x8880000a), &injection);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 @59  	ocelot_ifh_set_dest(injection, BIT(dp->index));

db->index is less than db->num_ports which 32 or less but sometimes it
comes from the device tree so who knows.  The ocelot_ifh_set_dest()
function takes a u64 though and that suggests that BIT() should be
changed to BIT_ULL().

9d88a16c0fc930 Vladimir Oltean 2021-02-13  60  
9d88a16c0fc930 Vladimir Oltean 2021-02-13  61  	return skb;
9d88a16c0fc930 Vladimir Oltean 2021-02-13  62  }
9d88a16c0fc930 Vladimir Oltean 2021-02-13  63  
9d88a16c0fc930 Vladimir Oltean 2021-02-13  64  static struct sk_buff *seville_xmit(struct sk_buff *skb,
9d88a16c0fc930 Vladimir Oltean 2021-02-13  65  				    struct net_device *netdev)
9d88a16c0fc930 Vladimir Oltean 2021-02-13  66  {
9d88a16c0fc930 Vladimir Oltean 2021-02-13  67  	struct dsa_port *dp = dsa_slave_to_port(netdev);
9d88a16c0fc930 Vladimir Oltean 2021-02-13  68  	void *injection;
9d88a16c0fc930 Vladimir Oltean 2021-02-13  69  
9d88a16c0fc930 Vladimir Oltean 2021-02-13  70  	ocelot_xmit_common(skb, netdev, cpu_to_be32(0x88800005), &injection);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 @71  	seville_ifh_set_dest(injection, BIT(dp->index));

Same.

9d88a16c0fc930 Vladimir Oltean 2021-02-13  72  
8dce89aa5f3274 Vladimir Oltean 2019-11-14  73  	return skb;
8dce89aa5f3274 Vladimir Oltean 2019-11-14  74  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (42328 bytes)