netdev - Re: [PATCH bpf-next 3/3] samples: bpf: do not unload prog within xdpsock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Feb 2021 10:22:15 +0100
From:   Björn Töpel <bjorn.topel@...el.com>
To:     John Fastabend <john.fastabend@...il.com>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        daniel@...earbox.net, ast@...nel.org, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     andrii@...nel.org, toke@...hat.com, magnus.karlsson@...el.com,
        ciara.loftus@...el.com
Subject: Re: [PATCH bpf-next 3/3] samples: bpf: do not unload prog within
 xdpsock

On 2021-02-15 21:24, John Fastabend wrote:
> Maciej Fijalkowski wrote:
>> With the introduction of bpf_link in xsk's libbpf part, there's no
>> further need for explicit unload of prog on xdpsock's termination. When
>> process dies, the bpf_link's refcount will be decremented and resources
>> will be unloaded/freed under the hood in case when there are no more
>> active users.
>>
>> While at it, don't dump stats on error path.
>>
>> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>> ---
> 
> Can we also use it from selftests prog so we have a test that is run there
> using this? Looks like xdpxceiver.c could do the link step as well?
> 

Yes! Good point!


Björn