lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Feb 2021 15:29:59 +0530 From: Calvin Johnson <calvin.johnson@....nxp.com> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: Russell King - ARM Linux admin <linux@...linux.org.uk>, Grant Likely <grant.likely@....com>, "Rafael J . Wysocki" <rafael@...nel.org>, Jeremy Linton <jeremy.linton@....com>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Cristi Sovaiala <cristian.sovaiala@....com>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>, Ioana Ciornei <ioana.ciornei@....com>, Madalin Bucur <madalin.bucur@....nxp.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Marcin Wojtas <mw@...ihalf.com>, Pieter Jansen Van Vuuren <pieter.jansenvv@...boosystems.io>, Jon <jon@...id-run.com>, Saravana Kannan <saravanak@...gle.com>, Randy Dunlap <rdunlap@...radead.org>, Laurentiu Tudor <laurentiu.tudor@....com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "linux.cj" <linux.cj@...il.com>, Diana Madalina Craciun <diana.craciun@....com>, netdev <netdev@...r.kernel.org>, linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>, ACPI Devel Maling List <linux-acpi@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Ioana Radulescu <ruxandra.radulescu@....com>, Jakub Kicinski <kuba@...nel.org> Subject: Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver On Mon, Feb 15, 2021 at 05:15:36PM +0200, Andy Shevchenko wrote: > On Mon, Feb 15, 2021 at 5:13 PM Andy Shevchenko > <andy.shevchenko@...il.com> wrote: > > > > On Mon, Feb 15, 2021 at 2:33 PM Calvin Johnson > > <calvin.johnson@....nxp.com> wrote: > > > On Mon, Feb 08, 2021 at 04:28:31PM +0000, Russell King - ARM Linux admin wrote: > > > > ... > > > > > I think of_phy_is_fixed_link() needs to be fixed. I'll add below fix. > > > > > > --- a/drivers/net/mdio/of_mdio.c > > > +++ b/drivers/net/mdio/of_mdio.c > > > @@ -439,6 +439,9 @@ bool of_phy_is_fixed_link(struct device_node *np) > > > int len, err; > > > const char *managed; > > > > > > + if (!np) > > > + return false; > > > > AFAICS this doesn't add anything: all of the of_* APIs should handle > > OF nodes being NULL below. > > > > > /* New binding */ > > > dn = of_get_child_by_name(np, "fixed-link"); > > > if (dn) { > > Yes, of_get_next_child() and of_get_property() are NULL aware. > > So, the check is redundant. Yes, all the function calls in of_phy_is_fixed_link() handles NULL properly. I don't see any way this function can oops. Regards Calvin
Powered by blists - more mailing lists