netdev - Re: [Patch bpf-next v4 4/5] skmsg: move sk_redir from TCP_SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <602d78bbd1218_ddd220893@john-XPS-13-9370.notmuch>
Date:   Wed, 17 Feb 2021 12:12:43 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        John Fastabend <john.fastabend@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, duanxiongchun@...edance.com,
        Dongdong Wang <wangdongdong.6@...edance.com>,
        Jiang Wang <jiang.wang@...edance.com>,
        Cong Wang <cong.wang@...edance.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Sitnicki <jakub@...udflare.com>,
        Lorenz Bauer <lmb@...udflare.com>
Subject: Re: [Patch bpf-next v4 4/5] skmsg: move sk_redir from TCP_SKB_CB to
 skb

Cong Wang wrote:
> On Wed, Feb 17, 2021 at 10:40 AM John Fastabend
> <john.fastabend@...il.com> wrote:
> > > @@ -802,9 +809,10 @@ int sk_psock_tls_strp_read(struct sk_psock *psock, struct sk_buff *skb)
> > >                * TLS context.
> > >                */
> > >               skb->sk = psock->sk;
> > > -             tcp_skb_bpf_redirect_clear(skb);
> > > +             skb_dst_drop(skb);
> > > +             skb_bpf_redirect_clear(skb);
> >
> > Do we really need the skb_dst_drop() I thought we would have already dropped this here
> > but I've not had time to check yet.
> 
> Yes, I got some serious complaints from dst_release() when I didn't
> add skb_dst_drop().
> 
> Thanks.

OK thanks.